test(wasm-utxo): add unsigned_tx_id method and expand test coverage#263
Merged
OttoAllmendinger merged 1 commit intomasterfrom Apr 23, 2026
Merged
test(wasm-utxo): add unsigned_tx_id method and expand test coverage#263OttoAllmendinger merged 1 commit intomasterfrom
OttoAllmendinger merged 1 commit intomasterfrom
Conversation
OttoAllmendinger
changed the title
Implement unsigned_tx_id() method on BitGoPsbt that delegates to the network-aware unsigned_txid(), ensuring Zcash PSBTs hash the full wire format instead of stripped Bitcoin transaction. Add regression test verifying PsbtAccess::unsigned_tx_id matches BitGoPsbt::unsigned_txid across all networks and signature states. For Zcash, explicitly verify the txid differs from the stripped Bitcoin format. Fixes a regression introduced in commit bd20d68. Issue: BTC-0 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-0.fix-zcash-txid
branch
from
1cd6fc7 to
a8fc88d
Compare
lcovar
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement unsigned_tx_id() method on BitGoPsbt that delegates to
the network-aware unsigned_txid(), ensuring Zcash PSBTs hash the full
wire format instead of stripped Bitcoin transaction.
Add regression test verifying PsbtAccess::unsigned_tx_id matches
BitGoPsbt::unsigned_txid across all networks and signature states.
For Zcash, explicitly verify the txid differs from the stripped
Bitcoin format.
Fixes a regression introduced in commit bd20d68.
Issue: BTC-0
Co-authored-by: llm-git llm-git@ttll.de